dsmiley commented on code in PR #3503:
URL: https://github.com/apache/solr/pull/3503#discussion_r2296337974
##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -618,7 +618,8 @@ public static class NodeConfigBuilder {
private String defaultZkHost;
private Set<Path> allowPaths = Collections.emptySet();
private List<String> allowUrls = Collections.emptyList();
- private boolean hideStackTrace = Boolean.getBoolean("solr.hideStackTrace");
+ private boolean hideStackTrace =
+
!(Boolean.parseBoolean(System.getProperty("solr.responses.stacktrace.enabled",
"true")));
Review Comment:
EnvUtils?
##########
solr/solrj/src/resources/DeprecatedSystemPropertyMappings.properties:
##########
@@ -19,3 +19,4 @@
solr.enable.remote.streaming=solr.requests.streaming.remote.enabled
solr.enable.stream.body=solr.requests.streaming.body.enabled
solr.delete.unknown.cores=solr.cloud.startup.delete.unknown.cores.enabled
solr.config.set.forbidden.file.types=solr.configset.forbidden.file.types
+solr.hide.stack.trace=solr.responses.stacktrace.enabled
Review Comment:
it'd be neat if there was a way to reflect that we inverted a boolean. Like
use an exclamation in the beginning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
