murblanc commented on PR #3507: URL: https://github.com/apache/solr/pull/3507#issuecomment-3221947816
Not sure I understand the reason for this refactoring which seems to introduce initialization order issues (`coreContainer.getZkController()` not yet instantiated when `DistributedCollectionCommandContext` is constructed). There are 18 occurrences of `if (isZooKeeperAware())` in `CoreContainer` of this PR, so if the goal is to remove SolrCloud concerns from `CoreContainer`, I'd suggest to first decide the strategy then apply it to the various components (`DistributedCollectionCommandRunner` would be one of those). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
