iamsanjay commented on code in PR #3511: URL: https://github.com/apache/solr/pull/3511#discussion_r2303720633
########## solr/ui/src/commonMain/kotlin/org/apache/solr/ui/components/collections/data/ClusterStatusModels.kt: ########## Review Comment: +1 to separate file for data classes and common data classes. Comments are sometimes become hard-to-manage, I'd like comment where it does not make sense to dev, but for instance if the field name is replicationFactor then we know what it represents. Same goes for any functions such as getCollectionData/reloadCollection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
