cpoerschke commented on code in PR #3495:
URL: https://github.com/apache/solr/pull/3495#discussion_r2304105123
##########
solr/core/src/test/org/apache/solr/handler/TestStressThreadBackup.java:
##########
@@ -334,7 +335,7 @@ private void validateBackup(final Path backup) throws
IOException {
final int numRealDocsExpected = Integer.parseInt(m.group());
try (Directory dir = FSDirectory.open(backup)) {
- TestUtil.checkIndex(dir, 0, true, true, null);
+ TestUtil.checkIndex(dir, CheckIndex.Level.MIN_LEVEL_FOR_SLOW_CHECKS,
true, true, null);
Review Comment:
Hadn't given it too much thought, the Lucene PR for the signature change
replaced `true, true, true` with `CheckIndex.Level.MIN_LEVEL_FOR_SLOW_CHECKS,
true, true` albeit it in a test, and if the highest level is also the most
comprehensive and thus slowest that may align with stress testing, perhaps.
If changing to level 1, any preferences w.r.t.
`MIN_LEVEL_FOR_CHECKSUM_CHECKS` vs. `MIN_VALUE` vs. `DEFAULT_VALUE` (or I guess
technically `1` is on the table too)?
```suggestion
TestUtil.checkIndex(dir, CheckIndex.Level.DEFAULT_VALUE, true, true,
null);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
