aruggero commented on PR #3418: URL: https://github.com/apache/solr/pull/3418#issuecomment-3232953304
Hi @ercsonusharma, We reviewed everything again with @alessandrobenedetti. In general, the current status of the contribution is ok for us; we agree with the observations of the other reviewers. About previously highlighted points: - About the maxQueries parameter, the discussion is complicated, so ok. Let's keep it as it is. - About supporting more than one combiner, since this is not adding too much complexity to the contribution, let's keep it as it is. Is it worth adding some additional tests to check the behaviour of this new query component with highlighting/faceting? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
