dsmiley commented on code in PR #3505:
URL: https://github.com/apache/solr/pull/3505#discussion_r2308908931
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -291,7 +292,7 @@ private HttpClient createHttpClient(Builder builder) {
httpClient.setExecutor(this.executor);
httpClient.setStrictEventOrdering(false);
httpClient.setConnectBlocking(true);
- httpClient.setFollowRedirects(false);
+
httpClient.setFollowRedirects(Boolean.TRUE.equals(builder.followRedirects));
Review Comment:
I merely moved the same logic to a safe spot to execute that logic. The
suggested alternative is equivalent & fine; it's a matter of taste.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
