ppkarwasz opened a new pull request, #3603:
URL: https://github.com/apache/solr/pull/3603
This PR updates all Log4j artifacts to version **2.25.1** and includes a few
related cleanups:
* Supersedes #3079.
* Removes explicit dependencies on `osgi.annotation` and
`biz.aQute.bnd.annotation`.
* Since Log4j 2.25.0, Gradle Module Metadata automatically adds these as
transitive compile-only dependencies, so declaring them directly is no longer
needed.
* This still avoids `-Xlint:classfile` compiler warnings without extra
dependencies.
* Excludes `spotbugs-annotations` (brought in transitively via Apache POI).
* It is not required for the build and causes license check failures,
because SpotBugs (and its annotations) are LGPL-2.1 licensed.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my
code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request
title.
- [x] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended, not available for
branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
