epugh commented on code in PR #3604:
URL: https://github.com/apache/solr/pull/3604#discussion_r2317359598
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java:
##########
@@ -702,13 +700,6 @@ public static void createCollectionZkNode(
}
}
- // if the config name wasn't passed in, use the default
- if (!collectionProps.containsKey(ZkController.CONFIGNAME_PROP))
- collectionProps.put(ZkController.CONFIGNAME_PROP,
defaultConfigName);
Review Comment:
Let me know what you think on this.. no tests failed... thoguh I am
starting to realize we may have a lot of code paths with no tests in this area
;-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
