cpoerschke commented on code in PR #3418:
URL: https://github.com/apache/solr/pull/3418#discussion_r2319049507
##########
solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java:
##########
@@ -82,6 +82,14 @@ public void prepare(ResponseBuilder rb) throws IOException {
rb.setNeedDocSet(true);
rb.doFacets = true;
+ if (rb instanceof CombinedQueryResponseBuilder crb) {
+ crb.responseBuilders.forEach(
+ thisRb -> {
+ thisRb.setNeedDocSet(true);
+ thisRb.doFacets = true;
+ });
+ }
+
Review Comment:
> ... Maybe CombinedQueryComponent could at some point after the other
components to their preparation, it could propagate settings from parent to
children using new code to do so on CombinedQueryResponseBuilder. ...
I had a similar thought.
Thinking specifically about the faceting component though, I'm curious how
that interacts with combined queries:
* in the case of the highlighting component, if we have (say) `title:sales`
and `title:report` as the two lexical queries being combined then we wish for
the matching term to be highlighted in each document.
* in the case of the faceting component, faceting by (say) some language id
field that the document has, how would the facet counts from the two queries be
combined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
