dsmiley commented on code in PR #3610:
URL: https://github.com/apache/solr/pull/3610#discussion_r2320340119
##########
solr/core/src/java/org/apache/solr/cloud/DistributedClusterStateUpdater.java:
##########
@@ -94,11 +83,9 @@ public DistributedClusterStateUpdater(boolean
useDistributedStateUpdate) {
this.useDistributedStateUpdate = useDistributedStateUpdate;
if (log.isInfoEnabled()) {
log.info(
- "Creating DistributedClusterStateUpdater with
useDistributedStateUpdate="
- + useDistributedStateUpdate
- + ". Solr will be using "
- + (useDistributedStateUpdate ? "distributed" : "Overseer based")
- + " cluster state updates."); // nowarn
+ "Creating DistributedClusterStateUpdater with
useDistributedStateUpdate={}. Solr will be using {} cluster state updates.",
Review Comment:
I suggest we log nothing _here_. Instead log in ZkController initialization
to say whether the Overseer is enabled or disabled. Don't bother doing so in
this PR; it better belongs in #3524 in ZkController when `overseerEnabled` is
determined. I'll do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
