malliaridis commented on code in PR #3227:
URL: https://github.com/apache/solr/pull/3227#discussion_r2340579473
##########
gradle/libs.versions.toml:
##########
@@ -353,7 +356,7 @@ eclipse-jetty-xml = { module =
"org.eclipse.jetty:jetty-xml", version.ref = "ecl
eclipse-jgit-jgit = { module = "org.eclipse.jgit:org.eclipse.jgit",
version.ref = "eclipse-jgit" }
essenty-lifecycle = { module = "com.arkivanov.essenty:lifecycle", version.ref
= "essenty" }
fasterxml-jackson-bom = { module = "com.fasterxml.jackson:jackson-bom",
version.ref = "fasterxml" }
-fasterxml-jackson-core-annotations = { module =
"com.fasterxml.jackson.core:jackson-annotations", version.ref = "fasterxml" }
+fasterxml-jackson-core-annotations = { module =
"com.fasterxml.jackson.core:jackson-annotations", version.ref =
"fasterxml-annotations" }
Review Comment:
In theory it is necessary to add the BOM as platform dependency to all
modules that use a fasterxml dependency covered by it. But since we depend on
the API module and added it as platform dependency there, it is not necessary,
so I skipped the redundancy.
Ideally we find a way at some point (e.g. via regex) to distinguish BOMs
from other dependencies and add them to our platform module, so that we do not
have to add BOMs explicitly to other modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
