cpoerschke commented on code in PR #3496:
URL: https://github.com/apache/solr/pull/3496#discussion_r2353113981
##########
solr/core/src/test/org/apache/solr/spelling/SpellCheckCollatorTest.java:
##########
@@ -756,4 +762,106 @@ public void testWithCursorMark() {
List<?> collations = (List<?>) collationList.getAll("collation");
assertEquals(1, collations.size());
}
+
+ @Test
+ @SuppressWarnings("deprecation")
Review Comment:
Thanks for expanding the test coverage here! Unfortunately I'm not familiar
enough with the spell check functionality to meaningfully review it, sorry.
However, am curious w.r.t. what the deprecated stuff is and if/how perhaps it
could be avoided, for this new test addition only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
