adamjq commented on code in PR #3665:
URL: https://github.com/apache/solr/pull/3665#discussion_r2356862927
##########
solr/core/src/java/org/apache/solr/metrics/SolrMetricManager.java:
##########
@@ -773,7 +794,19 @@ public SdkMeterProvider meterProvider(String providerName)
{
var reader = new FilterablePrometheusMetricReader(true, null);
// NOCOMMIT: We need to add a Periodic Metric Reader here if we
want to push with OTLP
// with an exporter
- var provider =
SdkMeterProvider.builder().registerMetricReader(reader);
+ var provider =
+ SdkMeterProvider.builder()
+ .registerMetricReader(reader)
+ .registerView(
+ InstrumentSelector.builder()
Review Comment:
This scales out the default OTEL histogram boundaries by 1000 so that
everything doesn't end up in the `"+Inf"` bucket. See:
https://github.com/apache/solr/pull/3665#issuecomment-3300386898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
