iamsanjay commented on PR #3656: URL: https://github.com/apache/solr/pull/3656#issuecomment-3308112856
I think it comes down to how we want to approach this. First one is let’s keep everything on the component side so there’s a consistent rule everyone can follow. That said, when I was working on a dialog with four or five remember states, moving all of them into the component felt cumbersome. A good rule of thumb could be: if a state isn’t really used on the component side, we can safely keep it within the composable instead. If there’s a specific need—like in the case of configsets, where expanding should trigger a fetch to keep the data updated—we can handle it on the component side. But for now, using remember is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
