dsmiley commented on code in PR #3673:
URL: https://github.com/apache/solr/pull/3673#discussion_r2364991376
##########
solr/CHANGES.txt:
##########
@@ -248,6 +248,9 @@ Improvements
* SOLR-17641: Solr is now able to start on Java 24 and later, but with
Security Manager disabled (Houston Putman, Jan Høydahl)
+* SOLR-17921: The BaseHttpClusterStateProvider now refreshes liveNodes in the
background. This will reduce spikes in request
Review Comment:
ClusterStateProvider is too internal for our users to know what it is (nor
should they). I suggest:
"SolrJ CloudSolrClient configured with a Solr URL (not ZK) now ...".
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/ClusterStateProviderTest.java:
##########
@@ -344,9 +346,17 @@ public void testClusterStateProviderLiveNodesWithNewNode()
throws Exception {
cluster.stopJettySolrRunner(jettyNode2);
waitForCSPCacheTimeout();
+ long start = System.nanoTime();
Review Comment:
I prefer time variables have a unit suffix like "Ns" or "Ms" for clarity
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2ClusterStateProvider.java:
##########
@@ -34,6 +34,7 @@ public Http2ClusterStateProvider(List<String> solrUrls,
Http2SolrClient httpClie
@Override
public void close() throws IOException {
+ super.close();
Review Comment:
super.close should be called last so we decontruct top-down (LIFO stack).
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClusterStateProvider.java:
##########
@@ -45,6 +45,7 @@ protected SolrClient getSolrClient(String baseUrl) {
@Override
public void close() throws IOException {
+ super.close();
Review Comment:
super.close should be called last so we decontruct top-down (LIFO stack).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
