andywebb1975 opened a new pull request, #3676: URL: https://github.com/apache/solr/pull/3676
https://issues.apache.org/jira/browse/SOLR-17923 # Description The existing `join` functions discard tuples from the Right stream that don't appear in the Left. Adding a `fullOuterJoin` function will enable the construction of e.g. Reciprocal Rank Fusion (RRF) stream expressions that require non-matching tuples from the Right stream to be included. # Solution This PR adds a `fullOuterJoin` function based on `leftOuterJoin`. # Tests The tests are based on those for `leftOuterJoin` - I've also included a new pair of tests that illustrate the difference in behaviour between that and `fullOuterJoin`, with one new `id` appearing in the output. The `right.field` syntax used in existing tests confused me as it looked like special syntax. I've replaced the dots with underscores as I think this makes it clearer. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
