aruggero opened a new pull request, #3680: URL: https://github.com/apache/solr/pull/3680
https://issues.apache.org/jira/browse/SOLR-17815 # Description Added the possibility to pass the Lucene [filteredSearchThreshold](org.apache.lucene.search.knn.KnnSearchStrategy.Hnsw#filteredSearchThreshold) parameter as a Solr Knn query parameter. # Solution The parameter has been added to the [KnnQParser](solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java) class, and the [getKnnVectorQuery](org.apache.solr.schema.DenseVectorField#getKnnVectorQuery) method has been adapted to accept this parameter and call the appropriate KnnVectorQuery constructor in Lucene. # Tests Two tests have been added in [DenseVectorFieldTest](org/apache/solr/schema/DenseVectorFieldTest.java) to check that the [getKnnVectorQuery](org.apache.solr.schema.DenseVectorField#getKnnVectorQuery) method returns an object with the expected threshold set. Two tests have been added in [KnnQParserTest](org/apache/solr/search/neural/KnnQParserTest.java) to check that the new filteredSearchThreshold parameter is correctly parsed and set. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [X] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
