tflobbe commented on code in PR #3690:
URL: https://github.com/apache/solr/pull/3690#discussion_r2379326787
##########
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java:
##########
@@ -122,14 +122,15 @@ public static void initialize() {
@SuppressWarnings("deprecation")
Review Comment:
I think the rationale behind the deprecation was as a warning to developers
writing (integration) tests that disabling the check was not the preferred way
to deal with the host allow list, but instead, they should include the list of
hosts. This was happening in, for example TestJsonFacets from what I could see
in the original commit. It seems like there were some problems with this
approach that could cause some "Address already in use" (fixed by hoss
[here](https://github.com/apache/solr/commit/3fe4d0a30aab2fbe979c5d42014ac7d78260d0a4)),
so he removed that part and disabled the check in that test too.
I'm fine with removing the deprecation if this makes things simpler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
