psalagnac commented on code in PR #3692:
URL: https://github.com/apache/solr/pull/3692#discussion_r2379584544
##########
solr/core/src/java/org/apache/solr/cloud/SolrZkServer.java:
##########
@@ -138,8 +139,8 @@ public void start() {
return;
}
- if (System.getProperty(ZK_WHITELIST_PROPERTY) == null) {
- System.setProperty(ZK_WHITELIST_PROPERTY, "ruok, mntr, conf");
+ if (EnvUtils.getProperty(ZK_ALLOWLIST_PROPERTY) == null) {
Review Comment:
Not sure we want to use `EnvUtil` there. It checks environment variables,
but I think Zookeeper code will work only with a system property.
Probably a case will never happen anyway...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
