liangkaiwen opened a new pull request, #3682: URL: https://github.com/apache/solr/pull/3682
https://issues.apache.org/jira/browse/SOLR-17806 # Description Replace existing segment merge metrics with consistent counters # Solution * Enabled segment merge metrics by default (configurable threshold for major merges behavior is unchanged) * Removed the index merge running gauge metrics Added the following index merge metrics: * solr_indexwriter_merge_time * solr_indexwriter_merge_errors * solr_indexwriter_flushes * solr_indexwriter_merges * solr_indexwriter_docs_merged * solr_indexwriter_docs_deleted * solr_indexwriter_segments Also added labels for `merge_type` (minor / major) and `merge_state` (started / finished). In this way the counters are consistent and monotonically increasing. To get the current state of a merge, the current started metric can be subtracted from the current finished metric. # Tests * Updated existing merge metrics tests # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [X] I have added tests for my changes. - [X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
