mlbiscoc commented on code in PR #3509:
URL: https://github.com/apache/solr/pull/3509#discussion_r2383445917
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -1018,8 +1040,52 @@ private void loadInternal() {
"unloaded",
SolrInfoBean.Category.CONTAINER.toString(),
"cores");
+
Path dataHome =
cfg.getSolrDataHome() != null ? cfg.getSolrDataHome() :
cfg.getCoreRootDirectory();
+
+ solrMetricsContext.observableLongGauge(
+ "solr_cores_filesystem_disk_space",
+ "Disk metrics for Solr's data home directory",
Review Comment:
Descriptions to my knowledge are not used in anyway for aggregation. So if
they get picked up from 2 Solr nodes, each with a different description, that
is ok. Prometheus backend or whatever backend they use should just looks at
metric names and attributes. Descriptions are only there for user
understanding. Also helps that updating descriptions are always backwards
compatible to change, so we can update this later on if we need improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
