sigram commented on PR #3748: URL: https://github.com/apache/solr/pull/3748#issuecomment-3386496518
IMHO both should stay. `TimeLimitingBulkScorer` is a misnomer in our case - while it works with Lucene's `QueryTimeout`, which suggests time-based limits, in Solr it works with `QueryLimits` that represent other types of limits, too. So it's quite possible to trip other limit types (cpu, mem) while executing `BulkScorer.score`, and it doesn't have to be directly related to the low-level `Directory` operations that EDR protects us from. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
