mlbiscoc commented on code in PR #3707:
URL: https://github.com/apache/solr/pull/3707#discussion_r2392195211
##########
solr/core/src/java/org/apache/solr/metrics/SolrCoreMetricManager.java:
##########
@@ -187,9 +187,6 @@ public void close() throws IOException {
}
metricManager.unregisterGauges(
solrMetricsContext.getRegistryName(), solrMetricsContext.getTag());
-
- metricManager.removeRegistry(solrMetricsContext.getRegistryName());
- registeredProducers.clear();
Review Comment:
Metrics are not accessible on core delete or unload. Those metrics are
completely gone and the registry goes with it. This change was for the reload
scenario. Turns out, it didn't reset normal counters and meters in Dropwizard
and never actually deletes the registry. Only the gauges it seems.
##########
gradle/testing/randomization/policies/solr-tests.policy:
##########
@@ -277,3 +277,7 @@ grant {
// Allow testing effects of customized or bug-fixed dependencies locally
(also need to add mavenLocal() to build)
permission java.io.FilePermission "${user.home}${/}.m2${/}repository${/}-",
"read";
};
+
+grant {
Review Comment:
Not accident. Needed it for `JvmMetricsTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
