dsmiley commented on code in PR #4048:
URL: https://github.com/apache/solr/pull/4048#discussion_r2691632135
##########
solr/solrj-streaming/build.gradle:
##########
@@ -39,10 +39,5 @@ dependencies {
testImplementation libs.junit.junit
testImplementation libs.hamcrest.hamcrest
- testImplementation(libs.apache.zookeeper.zookeeper, {
- exclude group: "org.apache.yetus", module: "audience-annotations"
- })
- permitTestUnusedDeclared libs.apache.zookeeper.zookeeper
-
permitTestUsedUndeclared project(':solr:solrj-streaming') // duh!
Review Comment:
Sure I could switch to `testImplementation`, and maybe I should but the
reason the line is there at all is because of this plugin's flaw. And the
"permit" use is basically always a flaw, so the line as-is shows that this
plugin is flawed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
