epugh commented on code in PR #3904:
URL: https://github.com/apache/solr/pull/3904#discussion_r2695066053
##########
solr/core/src/java/org/apache/solr/core/CorePropertiesLocator.java:
##########
@@ -240,4 +242,23 @@ protected Properties buildCoreProperties(CoreDescriptor
cd) {
p.putAll(cd.getPersistableUserProperties());
return p;
}
+
+ protected void checkForExistingCore(CoreDescriptor cd) {
+ if (Files.exists(cd.getInstanceDir())) {
+ final boolean deleteUnknownCores =
+
EnvUtils.getPropertyAsBool("solr.cloud.delete.unknown.cores.enabled", false);
Review Comment:
yeah, I guess the only reason that it has `.cloud.` in the name is that we
don't see this behavior in non cloud use cases, probably because non cloud
users don't create/delete cores rapidly, at least most don't.. The whole
"let me create/remove/move/delete cores" really feel slike a cloud feature
(driven by alias use, adding replicates etc).
I will check and see about adding in the cloud descriptor check.. or go
with the name you proposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
