gerlowskija commented on code in PR #4046:
URL: https://github.com/apache/solr/pull/4046#discussion_r2695671686
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/DistributedCollectionConfigSetCommandRunner.java:
##########
@@ -439,21 +445,25 @@ public OverseerSolrResponse call() {
// hierarchy do no harm, and there shouldn't be too many of those.
lock.release();
} catch (SolrException se) {
- log.error(
- "Error when releasing collection locks for operation " +
action, se); // nowarn
+ if (log.isErrorEnabled()) {
+ log.error(
+ "Error when releasing collection locks for operation {}",
Review Comment:
I was actually wrong above - it looks like slf4j is now smart enough to
check for the "last-arg-is-a-throwable" case, even when invoking the varargs
method. (Realized this while talking to @HoustonPutman offline - thanks for
straightening me out!)
Sorry for the noise!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
