dsmiley commented on code in PR #3955:
URL: https://github.com/apache/solr/pull/3955#discussion_r2701217957
##########
solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java:
##########
@@ -1283,12 +1282,7 @@ private Long getNumCommits(HttpSolrClient sourceClient)
throws SolrServerExcepti
.withConnectionTimeout(15000, TimeUnit.MILLISECONDS)
.withSocketTimeout(60000, TimeUnit.MILLISECONDS)
.build()) {
- var req =
- new GenericSolrRequest(
- SolrRequest.METHOD.GET,
- "/admin/metrics",
- SolrRequest.SolrRequestType.ADMIN,
- SolrParams.of("wt", "prometheus"));
+ var req = new MetricsRequest(SolrParams.of("wt", "prometheus"));
Review Comment:
Tests ensure "just to be sure". I don't agree with redundantly setting
something in the params when it's the responsibility of the ResponseParser to
govern this particular matter. For example, lets say we finally switch to
using the HTTP header Accepts. We'll now need to find this place here and
remove the explicit "wt" later.
Any way, not a big deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
