epugh commented on PR #4058: URL: https://github.com/apache/solr/pull/4058#issuecomment-3764284337
> As this is the removal PR, I am curious -- did you remove the parameter with IntelliJ or did you use an LLM? Or worse, did you use IntelliJ like a text editor and do it manually? IntelliJ freaking excels at refactoring; you can trust it will mechanically / assuredly make the change. I did BOTH of those things... ;-(. And literally on the plane home I was thinking "Something is going wrong with my approach". I tried IntellJ and it doesn't want to refactor based on the changed method collides iwth another method witht he same signature. This was mentioned in hte ORIGINAL JIRA posting... I did discover the `CommitUpdateCommand` which encapsulates all these parameters. So I am going to take the slightly larger surgury to see if instead of passing all those paremters around, maybe I can instead just use this class instead? (Inspired by what @HoustonPutman is doing on the collection api...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
