epugh opened a new pull request, #4064: URL: https://github.com/apache/solr/pull/4064
https://issues.apache.org/jira/browse/SOLR-7003 # Description Second take at removing the `waitFlush` parameter. # Solution In this version, I introduced a `CommitOptions` object that wraps up all the various settings. In my previous attempt, dealing iwth all the various booleans and ints and strings in the methods in `SolrClient` was killing me.... This lets us deprecate a bunch of methods in `SolrClient` `optimize` and `commit` methods. I also found a whole bunch of places in our tests where we pass extra params into the `optimize` and `commit` methods that could be simplified to leverage existing defaults. # Tests Mostly reruning tests, and add a few small ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
