dsmiley commented on code in PR #3992: URL: https://github.com/apache/solr/pull/3992#discussion_r2724477125
########## changelog/unreleased/SOLR-18051-fix-double-registration-bug.yml: ########## @@ -0,0 +1,8 @@ +# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc +title: Fix phaser/semaphore double registration bug in HttpJettySolrClient Review Comment: Please merge not rebase (thus avoid force-push). We want our primary branches (e.g. `main`, `branch_10x`, ...) to have linear history in general, but in-progress feature branches -- no (doesn't matter). But I'd like to hear your point of view if you see that there's some value in it. I think there's value in the feature branch reflecting the reality of literally what you did (thus the merge). And of course, not resetting the PR review state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
