sigram commented on code in PR #4063:
URL: https://github.com/apache/solr/pull/4063#discussion_r2732443283
##########
solr/cross-dc-manager/src/java/org/apache/solr/crossdc/manager/consumer/KafkaCrossDcConsumer.java:
##########
@@ -532,29 +533,29 @@ protected void processResult(
"Sending message to dead letter queue because of max attempts
limit with current value = {}",
attempt);
kafkaMirroringSink.submitToDlq(item);
- metrics.counter(MetricRegistry.name(type.name(),
"failed-dlq")).inc();
+ metrics.incrementOutputCounter(type.name(), "failed-dlq");
} else {
kafkaMirroringSink.submit(item);
- metrics.counter(MetricRegistry.name(type.name(),
"failed-resubmit")).inc();
+ metrics.incrementOutputCounter(type.name(), "failed-resubmit");
Review Comment:
The `type` label indicates what type of request failed (one of UPDATE,
ADMIN, CONFIGSET), and then separately there's the `result` label.
I'm not sure what's the practical difference between two metrics (one of
success, one for failures) vs. one metric with labels?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
