epugh commented on code in PR #4064:
URL: https://github.com/apache/solr/pull/4064#discussion_r2734820179
##########
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##########
@@ -302,8 +302,10 @@ private void commitOnLeader(String leaderBaseUrl, String
coreName)
// ureq.getParams().set(DistributedUpdateProcessor.COMMIT_END_POINT,
true);
// ureq.getParams().set(UpdateParams.OPEN_SEARCHER, onlyLeaderIndexes);
// Why do we need to open searcher if "onlyLeaderIndexes"?
- ureq.getParams().set(UpdateParams.OPEN_SEARCHER, false);
- ureq.setAction(AbstractUpdateRequest.ACTION.COMMIT, false,
true).process(client);
+ ureq.setAction(
+ AbstractUpdateRequest.ACTION.COMMIT,
+
CommitOptions.forHardCommit().openSearcher(false).waitSearcher(true))
Review Comment:
so a hard commit already does waitSearcher(true) under the covers.
However, openSearcher(false) doesn't I don't think have any bearing on
waitSearcher...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
