epugh commented on code in PR #4084:
URL: https://github.com/apache/solr/pull/4084#discussion_r2736427898
##########
solr/core/src/java/org/apache/solr/handler/admin/CoreInfoHandler.java:
##########
@@ -0,0 +1,77 @@
+package org.apache.solr.handler.admin;
+
+import java.io.IOException;
+import java.lang.invoke.MethodHandles;
+import java.nio.file.Path;
+import java.util.Date;
+import org.apache.solr.common.util.SimpleOrderedMap;
+import org.apache.solr.core.SolrCore;
+import org.apache.solr.handler.RequestHandlerBase;
+import org.apache.solr.request.SolrQueryRequest;
+import org.apache.solr.response.SolrQueryResponse;
+import org.apache.solr.schema.IndexSchema;
+import org.apache.solr.security.AuthorizationContext;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * This handler returns core level info. See {@link
org.apache.solr.handler.admin.SystemInfoHandler}
+ */
+public class CoreInfoHandler extends RequestHandlerBase {
+ private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ @Override
+ public String getDescription() {
+ return "Get Core Info";
+ }
+
+ @Override
+ public Category getCategory() {
+ return Category.ADMIN;
+ }
+
+ @Override
+ public Name getPermissionName(AuthorizationContext request) {
+ return Name.CONFIG_READ_PERM;
+ }
+
+ @Override
+ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp)
throws Exception {
+ rsp.setHttpCaching(false);
Review Comment:
Does this request handler need `if
(AdminHandlersProxy.maybeProxyToNodes(req, rsp, getCoreContainer(req))) {` like
`SystemInfoHandler` has? Is that soemthing every class needs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
