gerlowskija commented on code in PR #4068: URL: https://github.com/apache/solr/pull/4068#discussion_r2738374219
########## changelog/unreleased/solr-18081-shard-request-tracker-replica-name.yml: ########## @@ -0,0 +1,9 @@ +# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc +title: ShardRequestTracker should index results by node and replica rather than just node. This fixes requests that had multiple responses from a single node that got over-written. Review Comment: [0] There might be a way to rephrase this to make the impact a little more comprehensible to the average user. Maybe: > Admin API responses now include the responses from *all* sub-requests, even in the case of colocated replicas. Meh - now that I've written it up, I don't really like my alternative any better. It's a tough thing to convey concisely. Feel free to ignore me. ########## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ########## @@ -533,6 +577,15 @@ private static NamedList<Object> waitForCoreAdminAsyncCallToComplete( } continue; + } else if (r.equals("submitted")) { Review Comment: [+1] Great catch. Obviously a different PR, but we should really convert this logic here and elsewhere into a switch-case, so we'll get warnings if we ever neglect to handle a particular value as we did here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
