HoustonPutman commented on PR #3916: URL: https://github.com/apache/solr/pull/3916#issuecomment-3821434593
Ultimately I think there is 2 things left to do here: - Currently we are keeping track of all previous locks in the command-calling chain. We only need the previous lock. It doesn't matter who else called that API, but each API should only guarantee locking for the things it calls, not 2 APIs down the chain. - I think there is a possibility of a dead-lock here. Where API-a locks collection an and API-b locks collection b, and API-a calls API-b and API-b calls API-a. Then calling API-a and API-b at the same time might cause a deadlock. We can fix this by insisting that sub-API requests are required to be in the same locking chain as the parent API request. I don't love making this caveat, but it would save us from dead-locking, and we can always relax the requirements later if we find a better way to eliminate deadlocks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
