eshabakhov opened a new pull request, #4090: URL: https://github.com/apache/solr/pull/4090
https://issues.apache.org/jira/browse/SOLR-16999 # Description Removed some static methods in AssertTool.java and the logic in these methods has been transferred into runAssert method. # Solution Remove static methods in AssertTool.java: - assertFileExists - assertFileNotExists - assertRootUser - assertNotRootUser - sameUser # Tests Existing tests were passed in AssertToolTest.java: - raisesExitCode100OnError() - checksForTheExistenceOfDirectoryThatExists() - checksForTheExistenceOfDirectoryThatDoesntExist() - checksForTheNonExistenceOfDirectoryThatExists() - checksForTheNonExistenceDirectoryThatDoesntExist() - checksForThePresenceOfSolrOnCorrectUrl() - checksForThePresenceOfSolrOnIncorrectUrl() - checksForTheAbsenceOfSolrOnCorrectUrl() - checksForTheAbsenceOfSolrOnIncorrectUrl() # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [-] I have added tests for my changes. - [-] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [-] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
