dsmiley commented on PR #3903: URL: https://github.com/apache/solr/pull/3903#issuecomment-3829053391
I hate a general `Utils` class for massive code-bases (like Solr); definitely lets not put anything of this nature there. Lets move this to `DocumentBuilder`. It has no state; just static methods. Right now it only converts a SolrInputDocument to a Lucene Document. But I could easily see expanding the scope here to do the reverse, which is what you added. Then maybe in some separate PR, RTG's methods might move there too (don't concern yourself with this unless you are in the mood). WDYT? If you don't agree then nevermind; lets just get on with merging this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
