gus-asf commented on code in PR #4080:
URL: https://github.com/apache/solr/pull/4080#discussion_r2776510974
##########
solr/core/src/test/org/apache/solr/handler/V2ApiIntegrationTest.java:
##########
@@ -114,26 +114,27 @@ public void testIntrospect() throws Exception {
}
@Test
- public void testWTParam() throws Exception {
+ public void testInvalidWTParamReturnsError() throws Exception {
V2Request request = new V2Request.Builder("/c/" + COLL_NAME +
"/get/_introspect").build();
- // TODO: If possible do this in a better way
+ // Using an invalid wt parameter should return a 500 error
Review Comment:
Sorry, just seeing this... I disagree with this comment. An invalid wt
parameter is a BAD REQUEST (400). The user's query will never succeed no matter
what state the server is in. The server is not in error, the request is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
