dsmiley commented on code in PR #4111: URL: https://github.com/apache/solr/pull/4111#discussion_r2776950162
########## dev-docs/changelog.adoc: ########## @@ -78,25 +78,11 @@ user.githubid=johngithub user.asfid=johnapache ---- -TIP: Aliases for `writeChangelog` task are `changelog` and `newChangelog`. - -== 4. Writing Good Entries - -* **Audience** is end-users and administrators, not committers. -* If the change is super minor, like a typo, don't bother adding a yaml file -* Keep the entry short and focused on the user impact. -* Choose the correct *type*: -** `added` for new features -** `changed` for improvements to existing code -** `fixed` for bug fixes -** `deprecated` for deprecated features -** `removed` for code removed in major releases -** `dependency_update` for updates to dependencies -** `security` for security-related changes Review Comment: removed "security" as I think this is an orthogonal matter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
