[
https://issues.apache.org/jira/browse/SOLR-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057067#comment-18057067
]
Eric Pugh commented on SOLR-18106:
----------------------------------
I reopened the PR and finished the changes... All the tests pass. If
changing this code somehow impacts the Coordinator feature, then I would be
very concerned that none of our tests seem to notice this!
I did a bit of poking aorund in the Ref Guide to learn more about the
Coordinator.. This is what I found:
[https://solr.apache.org/guide/solr/latest/deployment-guide/node-roles.html#coordinator-role..]
Do we have an entire mode that has no tests that would pick up any changes
like what I did?
> Remove SolrQueryRequest.getCloudDescriptor
> ------------------------------------------
>
> Key: SOLR-18106
> URL: https://issues.apache.org/jira/browse/SOLR-18106
> Project: Solr
> Issue Type: Sub-task
> Reporter: Eric Pugh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> This method has been deprecated, is only called in two places, and is easily
> inlined.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
