[
https://issues.apache.org/jira/browse/SOLR-18113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057664#comment-18057664
]
David Smiley commented on SOLR-18113:
-------------------------------------
{quote}ZookeeperInfoHandler currently uses the "raw" request handler, but it
returns standard JSON. If we convert it to json, we don't need "raw" defined
in ResponseWriterRegistery anymore.
{quote}
I agree ZIH could be improved to not need "raw" but I think "raw" should
continue to be in ResponseWriterRegistery (a new thing) since it's very
system/internal. Perhaps other node handlers might want to use it for valid
reasons. I'm surprised Prometheus format doesn't.
{quote}it looks for a /clusterstate.json from the admin ui, we should update
the admin ui to consume the standard format and elminate this werid use case.
It's brittle.
{quote}
+1
{quote}contentstream is deprecated in favour of contentwriter.
{quote}
I had something to do with its deprecation. I think it may need to be
un-deprecated. It's awkward because the intent was for a SolrJ user to no
longer see it... but it turns out it's used pervasively on the server side.
It's defined in SolrJ, though. A worthwhile goal is to remove it from SolrJ,
which will address a bunch of deprecated methods relating to it over there. I
filed SOLR-18116
{quote}probably for a v2 version, but think about /admin/zookeeper being
/admin/clusterstate and dropping the zookeeper term?
{quote}
I think ZooKeeper naming is appropriate here. That's literally what it is, and
it's not plug-gable, and I don't see that changing. Using "clusterstate" here
would be an abuse/expansion of what clusterstate has meant to be so far –
(basically what's exposed from ClusterState.java).
> Review ZookeeperInfoHandler
> ---------------------------
>
> Key: SOLR-18113
> URL: https://issues.apache.org/jira/browse/SOLR-18113
> Project: Solr
> Issue Type: Improvement
> Reporter: Eric Pugh
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We should look at a few things in ZookeeperInfoHandler:
> * ZookeeperInfoHandler currently uses the "raw" request handler, but it
> returns standard JSON. If we convert it to json, we don't need "raw"
> defined in ResponseWriterRegistery anymore.
> * it looks for a /clusterstate.json from the admin ui, we should update the
> admin ui to consume the standard format and elminate this werid use case.
> It's brittle.
> * contentstream is deprecated in favour of contentwriter.
> * probably for a v2 version, but think about /admin/zookeeper being
> /admin/clusterstate and dropping the zookeeper term?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
