epugh commented on code in PR #4131:
URL: https://github.com/apache/solr/pull/4131#discussion_r2801966377
##########
solr/core/src/test/org/apache/solr/EchoParamsTest.java:
##########
@@ -40,17 +40,19 @@ public void test() {
// call them directly above:
private void defaultEchoParams() {
- lrf.args.put("wt", "xml");
+ // lrf.args.put("wt", "xml");
Review Comment:
@dsmiley I was thinking about maybe eliminating `args` and just having
params like I did in this test. There are some other places where we have a
mix of `lrf.args` and then a list of params. I *think* that the more modern
types of tests JUST take params, don't have the args concept, so to eliminate
TestHarness we have to eliminate `args` anyway????
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
