dsmiley commented on code in PR #4147:
URL: https://github.com/apache/solr/pull/4147#discussion_r2830758601
##########
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleEmbeddedTest.java:
##########
@@ -17,17 +17,10 @@
package org.apache.solr.client.solrj.embedded;
import org.apache.solr.client.solrj.SolrExampleTests;
-import org.junit.BeforeClass;
/**
* This runs SolrServer test using
*
* @since solr 1.3
*/
-public class SolrExampleEmbeddedTest extends SolrExampleTests {
-
- @BeforeClass
Review Comment:
Ah. I did a refactor and pushed it to this PR. Renamed this as I think
this test is the best test to test EmbeddedSolrServer itself. Using
EmbeddedSolrServer in createNewClient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
