gerlowskija opened a new pull request, #4163:
URL: https://github.com/apache/solr/pull/4163
# Description
Erick Erickson inserted exception stacktrace "shortening" as a part of
SOLR-12055 back in 2019. This appears to have been done for brevity reasons at
the time, but it's too much of a hindrance when it comes to debugging issues
with tests or in production.
# Solution
This commit reverses course on this earlier decision by removing the
explicit `%ex{short}` specifier in all of our log4j2.xml configs. (log4j's
PatternLayout will append exception information by default so we don't need to
include any specifier for this at all now that the truncation is being removed.)
# Tests
Manual testing of our assembled artifact. Ensure existing logging tests
continue to pass. Ensure that failing tests print a full exception.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my
code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request
title.
- [x] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended, not available for
branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
