[
https://issues.apache.org/jira/browse/SOLR-17549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062164#comment-18062164
]
Jason Gerlowski commented on SOLR-17549:
----------------------------------------
bq. I think we may need to prioritze a fix and not just bandaid it.
I'm also anti-bandaid; I assume everyone is? That's why, as I mentioned above,
I'm actively working on this.
I was mainly trying to highlight that there *is* a path forward for any PRs you
already had in flight and were eager to merge.
If you find yourself writing PRs that touch huge numbers of tests and you're
leery of re-work on those tests after this JIRA gets fixed...then I totally
agree that you should hold off on those until this JIRA gets fixed. But also,
I'm not sure what you mean by "all the tests"...it's hard to envision a PR
that'd *require* rolling out a new SolrRequest implementation to reams and
reams of tests.
> Reconsider error-handling in generated-v2 SolrResponses
> -------------------------------------------------------
>
> Key: SOLR-17549
> URL: https://issues.apache.org/jira/browse/SOLR-17549
> Project: Solr
> Issue Type: Bug
> Components: SolrJ, v2 API
> Affects Versions: 10.0
> Reporter: Jason Gerlowski
> Priority: Blocker
> Labels: V2
> Fix For: 10.1
>
>
> In most cases upon receiving an HTTP response, SolrClients will immediately
> parse it into a NamedList and then inspect that NamedList to see whether a
> client-side exception should be triggered.
> Our generated v2-API SolrRequest/SolrResponse classes work differently. They
> never convert the response into a NamedList, instead using Jackson to put it
> into a strongly-typed POJO. -Additionally, response parsing occurs lazily -
> typically not until after the SolrResponse has been returned to callers and
> they've invoked a special "getParsed()" method.-
> The combined effect of these two differences is that all of the
> error-detection/exception-throwing code in SolrClient is skipped when making
> generated-v2 requests! Callers can still detect errors by manually
> inspecting their response POJOs, but anyone expecting SolrJ's "no exception
> means success" convention are in for a frustrating shock.
> We should change how response-parsing happens in the generated-v2 case to
> match the rest of SolrJ. (Or alternately - investigate some more intuitive
> way to communicate failure.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
