dsmiley commented on code in PR #4173:
URL: https://github.com/apache/solr/pull/4173#discussion_r2874795740
##########
solr/test-framework/src/test/org/apache/solr/cloud/ZkTestServerTest.java:
##########
Review Comment:
Instead, you can merely observe (once, manually) that the log message about
this matter has disappeared. Tests need to be maintained and add a cost in
perpetuity that I don't think is warranted for this matter.
##########
solr/core/src/java/org/apache/solr/cloud/SolrZkServer.java:
##########
@@ -208,6 +211,12 @@ public void stop() {
}
zkThread.interrupt();
}
+
+ static void ensureZkMaxCnxnsConfigured() {
+ if (System.getProperty(ZK_MAX_CNXNS_PROPERTY) == null) {
+ System.setProperty(ZK_MAX_CNXNS_PROPERTY, ZK_MAX_CNXNS_DEFAULT);
+ }
Review Comment:
lets use `System.getProperties().putIfAbsent(...) instead of multiple
operaitons
##########
solr/core/src/java/org/apache/solr/cloud/SolrZkServer.java:
##########
@@ -41,6 +41,8 @@ public class SolrZkServer {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
public static final String ZK_WHITELIST_PROPERTY =
"zookeeper.4lw.commands.whitelist";
+ public static final String ZK_MAX_CNXNS_PROPERTY = "zookeeper.maxCnxns";
+ public static final String ZK_MAX_CNXNS_DEFAULT = "0";
Review Comment:
Comment what this value semantically means. Infinite?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
