dsmiley opened a new pull request, #4196: URL: https://github.com/apache/solr/pull/4196
This is a preparatory refactoring step on a short journey to solr/benchmark supporting multiple backends (not just MiniSolrCloudCluster). This PR renames `bench/MiniClusterState.java` to `bench/SolrBenchState.java`, and flattens its structure, which had an inner class. Two lifecycle methods containing "miniCluster" in the name were replaced with "solr" to be generic, and I improved javadocs slightly. **That's it**; I held back on doing anything else; this is just a simple refactoring. _Any other code you see is as-is, unchanged_. This PR will make a future PR much easier to review from a diff standpoint, and/or it allows more baby-steps. I suppose one might say: why not embrace JMH's class / injection design on this journey, such that MiniClusterState would continue to exist but so would other future ones like a hypothetical RemoteSolrState. Pursuing that would lead to a common base class, holding most of the functionality that's there now (e.g. the index methods). I chose a different path in which a common/universal benchmark state class `SolrBenchState` will delegate to a `SolrBackend`. The instantiation/configuration is where the only difference lies. Subclassing could be done to handle that but there's so little to it that I didn't bother. Even if we wind up wanting that approach after all, I still think this PR is helpful to that possible eventuality as well, since we'd still need a `SolrBenchState` and containing most of what you see in it. https://issues.apache.org/jira/browse/SOLR-18126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
