gus-asf commented on code in PR #4120:
URL: https://github.com/apache/solr/pull/4120#discussion_r2902157089
##########
solr/core/src/java/org/apache/solr/servlet/RequiredSolrRequestFilter.java:
##########
@@ -77,6 +78,9 @@ protected void doFilter(HttpServletRequest req,
HttpServletResponse res, FilterC
// we want to prevent any attempts to close our request or response
prematurely
chain.doFilter(closeShield(req), closeShield(res));
+ } catch (SolrException e) {
Review Comment:
Turns out instantiating an AuditEvent parses par meters and that can throw
a SolrException, which I don't like, but stopped myself from fixing. Luckily we
have a test that sends bad data in the parameters and checks that it results
in 400 not 500 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
