[ 
https://issues.apache.org/jira/browse/SOLR-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064141#comment-18064141
 ] 

David Smiley commented on SOLR-18139:
-------------------------------------

BTW I had mentioned maybe tackling single-value Set, List, Empty as well, but 
then I remembered that there is one semantic difference.  The `of` methods 
demand non-null parameters.  Thus {{Collections.singletonList(null)}}, for 
example, accepts a null, whereas {{List.of(null)}} does not.  We should still 
_prefer_ the `of` when possible but we can't block the singleton methods.

> Remove use of Collections.emptyList() and Collections.emptySet()
> ----------------------------------------------------------------
>
>                 Key: SOLR-18139
>                 URL: https://issues.apache.org/jira/browse/SOLR-18139
>             Project: Solr
>          Issue Type: Wish
>            Reporter: Eric Pugh
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> [~dsmiley] has frequently mentioned this in PR review, lets get it sorted...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to