epugh commented on code in PR #4171:
URL: https://github.com/apache/solr/pull/4171#discussion_r2906029307
##########
solr/api/src/java/org/apache/solr/client/api/endpoint/NodeHealthApi.java:
##########
@@ -14,25 +14,22 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+package org.apache.solr.client.api.endpoint;
-package org.apache.solr.ui.domain
+import io.swagger.v3.oas.annotations.Operation;
+import jakarta.ws.rs.GET;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.QueryParam;
+import org.apache.solr.client.api.model.NodeHealthResponse;
-import io.ktor.http.Url
-import kotlinx.serialization.SerialName
-import kotlinx.serialization.Serializable
+/** V2 API definition for checking the health of a Solr node. */
+@Path("/node/health")
+public interface NodeHealthApi {
-@Serializable
-data class OAuthData(
- val clientId: String,
- val authorizationFlow: AuthorizationFlow,
- val scope: String,
- val redirectUris: List<Url>,
- val authorizationEndpoint: Url,
- val tokenEndpoint: Url,
-)
-
-@Serializable
-enum class AuthorizationFlow {
- Unknown,
- CodePKCE,
+ @GET
+ @Operation(
+ summary = "Determine the health of a Solr node.",
+ tags = {"node"})
+ NodeHealthResponse checkNodeHealth(
Review Comment:
Ahh... I like it. Honeslty, I was taking a pretty mechanistic approach,
versus really thinking through semantics since my goal was more about getting
rid of our old way of doing v2 versus "What should our API be like?".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
